Correction of the user responsible for the RESOURCE.UPDATE.LIMIT event #13066
Correction of the user responsible for the RESOURCE.UPDATE.LIMIT event #13066GeanJS wants to merge 1 commit intoapache:4.22from
RESOURCE.UPDATE.LIMIT event #13066Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
shwstppr
left a comment
There was a problem hiding this comment.
Can this go into 4.22/4.20 branch?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13066 +/- ##
============================================
+ Coverage 17.68% 18.01% +0.33%
- Complexity 15793 16608 +815
============================================
Files 5922 6029 +107
Lines 533096 542155 +9059
Branches 65209 66451 +1242
============================================
+ Hits 94275 97684 +3409
- Misses 428181 433456 +5275
- Partials 10640 11015 +375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dae8f06 to
d1c19dd
Compare
|
@blueorangutan package |
|
@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
@shwstppr, These changes do not apply to version 4.20, so I have rebased over 4.22. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17601 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Description
Currently, events of the
RESOURCE.UPDATE.LIMITtype do not register the user responsible for the performed action. Instead of that, the considered responsible user for the event is the account itself. Changes were made to consider the user responsible for the event as the one that actually performed the event's corresponding action.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
The tests were performed on version 4.22.1.0. In the graphical interface, I updated the resources of an account, and when navigating to the events tab, I was able to verify that the user responsible for the action was properly assigned.